Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototyped a dynamic library facility interface #7027

Closed

Conversation

mstewartgallus
Copy link
Contributor

I would appreciate if someone could help out with the Windows code on this pull request. I tried to test it using WINE but I couldn't figure out a way to set that up.

@emberian
Copy link
Member

@emberian
Copy link
Member

I have no idea why this failed. Does linking to kernel32.dll not work/is it done wrong?

@mstewartgallus
Copy link
Contributor Author

I'm getting very annoyed because I can't test on a Windows box. Would anyone be opposed to me making this initial pull request hidden behind #[cfg(target_os = ... checks so that it is built cleanly on Windows, and then having the Windows functionality be added in a another pull request by someone else later?

Also, what would be the best way to edit the history, and such to make the history of this pull request clear?

@huonw
Copy link
Member

huonw commented Jun 12, 2013

@sstewartgallus git rebase -i incoming and then use the f command on all commits but the first to merge them into that one. (You'll need to force push after doing this: git push -f ...)

bors added a commit that referenced this pull request Jun 13, 2013
I would appreciate if someone could help out with the Windows code on this pull request. I tried to test it using WINE but I couldn't figure out a way to set that up.
@bors bors closed this Jun 13, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 8, 2021
Use DefIdMap and similar aliases

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants